Looking to hire developers?
@fish-ladder
@redizork
Submitted
What are you most proud of, and what would you do differently next time?
none
What challenges did you encounter, and how did you overcome them?
none
What specific areas of your project would you like help with?
none
@fish-ladder
Posted
Looks good, Neven.
You could tweak your font sizes and spacing a bit to get closer to the design.
You might try a max-width on the cards in your mobile design so the don't stretch so much, unless that is the effect you are going for.
Nice work!
@mrcordova
Submitted
What are you most proud of, and what would you do differently next time?
I started with a mobile first approach, I would not change a thing.
What challenges did you encounter, and how did you overcome them?
I was having trouble getting the image to take half of the space in the card. I figured out I need to put flex: 1 on the picture element instead of the img element because the picture was a flex item.
What specific areas of your project would you like help with?
I welcome any general feedback but one question I had was how to use clamp more effectively. How would I decided what should be the min, best and max and if there some ratio to keep to other text on the screen.
@fish-ladder
Posted
I really liked seeing how you changed the cursor to a pointer - that is a detail I had not noticed before!
Since your desktop layout doesn't change size anyway, you could probably just use an exact width on your img of half the card size.
The border radius on your image in the mobile design could probably be tweaked to match the design files a bit more closely.
Overall, I really like your solution and looking at your code has given me some ideas to use in the future. Thanks!
Marked as helpful
@Luca-Sousa
Submitted
What are you most proud of, and what would you do differently next time?
I needed to study some pseudo-classes to choose the one that was most useful for styling the lists, which led me to research, which added to my studies.
What challenges did you encounter, and how did you overcome them?
It was a little more difficult to structure the HTML as well as the CSS, but with the analysis it became clearer how to solve the challenge. The use of lists was something new to use, as was the marker pseudo-class, which I didn't know, but it was very useful for styling the list.
What specific areas of your project would you like help with?
At the moment I won't need help, but as soon as something specific comes up, I will certainly seek help.
@fish-ladder
Posted
Hey Lucas, I liked how you used <strong> for the bold parts of the <li> items and your use of flexbox for centering. I think you could tweak some of the colors to more closely match the design (the style-guide gives you the specific color values if you want to use them). Nice work! Joe
What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?
.
What specific areas of your project would you like help with?
.
@fish-ladder
Posted
Looks great, Julie. The styling is precise and your CSS is very simple. I like your use of custom properties for the fonts and colors.
It looks like your img src in your html file doesn't point to the location of the picture file. If you correct the path, your image should show up. Hope that helps.
Marked as helpful
@Manishkrthakur
Submitted
@fish-ladder
Posted
You did a great job achieving the styling without nearly as many CSS declarations as I needed!
Try to find a way to vertically center the card (hint, Flexbox works great for this).
The border radius, shadow-box, padding, and avatar size could be tweaked a bit to more closely match the design.
Nice work, overall!
@ashvin-to
Submitted
@fish-ladder
Posted
Nice work, Ashvin! I am very new to web development so I don't feel very qualified to give feedback on your solution but I noticed a couple details I can point out.
