@gramme01
Posted
Hi, SimpleMB. Great job here. I noticed the div with class 'wrapper__background' has a 'src' and 'alt' attribute. Perhaps you meant to use an 'img' tag.
Also, good use of BEM. However I also noticed things like you were selecting elements with more than one class. The idea of BEM is that all selectors have a specificity of 10 i.e selected with only one class.
e.g: you had
'.menu__list .menu__item .menu__link'
to select the .menu__link
You should only use '.menu__link'
The advantage of this is that you can move the html element to anywhere in the block without having to change your css code.
All-in-all, great job done. And I must say this, you inspire me. You're consistently churning out great solutions to the challenges here.
@SimpleMB
Posted
Thank you Emmanuel :)
@SimpleMB
Posted
Hi, gramme01.
That div WAS an img. I renamed tag but forgot to delete img attributes.
As of BEM with SASS. This was my first project using it.That 3 level deep nesting was done by my SASS pre-processor.
Thank you for your feedback!