P
Matt Studdert• 13,611
@mattstuddert
Posted
Nice work on this challenge Jesse. The page looks great! 🙌
After having a look at your code I've only really got one suggestion:
- Whenever you add social icons with links, be sure to add them in an accessible way so that screen reader users know what they are. At the moment, the
a
tags have no text content inside them and so nothing would be read out to those users. Here's a tweet I wrote about creating accessible social icons that I hope you find useful.
Keep up the great work!
0
JesseStone• 370
@jesseburn
Posted
Thanks! I put in aria-label's for my a tags.
0