Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first page written with BEM, Sass and grunt as a tusk runner

tretyakvl 200

@tretyakvl

Desktop design screenshot for the Bookmark landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I tried to make the layout as pixel-perfect as possible. Because of that, the code has a lot of strange numbers like 0.9 rem, 1.65 rem, etc. Is it a good practice or should I make the code more uniform?

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Awesome work on this challenge, it looks really good and scales down to mobile really well!

It's completely fine to have rem values like that. Quite a common CSS setup is to have this rule for your html:

html {
  font-size: 62.5%;
}

This makes it so that 1rem == 10px and makes for easier calculations.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord