Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Intro with sign up form using JavaScript

@MichaelaBajanova

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Awesome work on this Michaela, you nailed the design! 👍

Here are some pointers after taking a look at your code:

  • Your input elements currently don't match up to any label tags. That's fine, although in this case, you should add the aria-label attribute to the input elements so that screen reader users know what the fields are for.
  • Your media queries are at the top of your CSS file at the moment. I'd strongly recommend putting media queries at the bottom of the file so that they overwrite declarations from above by using the cascading nature of CSS.
  • You've got this media query in your CSS at the moment: @media only screen and (min-width: 200px) and (max-width: 600px). This could be reduced to @media (max-width: 600px) as the min-width is so small that you might as well just remove it.

I hope these tips help. Keep up the great work, I'm looking forward to seeing your next solution!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord