P
Matt Studdert• 13,611
@mattstuddert
Posted
Great work on this Pedro! Nice to see you using min-width
media queries and working mobile-first too 👍
Here are a couple of things I picked up from looking at your code:
- In your HTML you have 3
h4
elements, but no other headings. I would always recommend starting ath1
and working down depending on the content hierarchy. This makes sure that the content outline for screen reader users is well structured. - I would also recommend not using IDs for styling purposes. Their specificity is really high and also they can't be reused on the same page. I always stick with classes, pseudo selectors, attribute selectors, and type selectors. It makes your CSS far more maintainable as it grows.
I hope these pointers help. Keep up the great work! 🙂
0