Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sass, CSS Grid

@Tarek-Zaher

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Awesome work on this and congrats on completing your first challenge! 🎉

I've just had a look at your code and I have a couple of pointers for you:

  • If you have input fields with no label be sure to add the aria-label attribute to the input with some label text. Otherwise, people using screen readers won't know what the input field is for.
  • Typically, the "Terms and Services" area below the form submit button would be a link to another page, so an a tag would be better suited over a span.
  • Great work using Sass and Grid. Also, nice to see you using relative units like rem and also min-width media queries.

Keep up the great work! 👍

1

@Tarek-Zaher

Posted

Thanks so much Matt! Those are some great tips I will definitely implement into my future projects. Have a great week!

0
P
Matt Studdert 13,611

@mattstuddert

Posted

You're welcome Tarek. I'm glad you found them useful!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord