P
Matt Studdert• 13,611
@mattstuddert
Posted
Awesome work on this and congrats on completing your first challenge! 🎉
I've just had a look at your code and I have a couple of pointers for you:
- If you have
input
fields with nolabel
be sure to add thearia-label
attribute to theinput
with some label text. Otherwise, people using screen readers won't know what the input field is for. - Typically, the "Terms and Services" area below the form submit button would be a link to another page, so an
a
tag would be better suited over aspan
. - Great work using Sass and Grid. Also, nice to see you using relative units like
rem
and alsomin-width
media queries.
Keep up the great work! 👍
1
Tarek-Zaher• 20
@Tarek-Zaher
Posted
Thanks so much Matt! Those are some great tips I will definitely implement into my future projects. Have a great week!
0
P
Matt Studdert• 13,611
@mattstuddert
Posted
You're welcome Tarek. I'm glad you found them useful!
0