Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive website using CSS and HTML

Maria 20

@mariakourtesi

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, My name is Maria, I am an absolute beginner so I would really appreciate any feedback. The challenge included Javascript but I've not been able to add it to the form. I am not sure how to do it. Thank you very much.

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Great work on this challenge Maria and congrats on submitting your first solution! 👍

Just a quick heads up that the links for your solution are currently in the wrong fields. The live site URL should be the link to the preview and the repo URL should be the link to your GitHub repo. You can edit this easily by clicking on the three dots by the title and selecting "Edit Solution" 🙂

Here are a few pointers after taking a look at your code:

  • input elements should always be made accessible to screen reader users. This usual means pairing each input with a label element. But if there are no labels in the design you can also add the aria-label attribute to each input element. Screen readers will then read out this text when the input is focused.
  • Nice work making it mobile responsive. One technique you might want to try in a future project is to use min-width media queries instead of max-width. This approach would mean you build out the mobile styles first and then add media queries to account for larger screen sizes. Many people find it to be a more efficient workflow, so would be worth seeing how you get on with it.
  • You're using position: absolute; quite a lot, which I'd warn against. This is because it means you're effectively sticking elements to the screen and can become unmanageable when you start to build more complex websites. Instead, I'd recommend learning Flexbox and Grid, which will help you when laying out your elements. Here are a couple of great (and free) tutorials for you to learn more:

I hope these pointers are helpful! Let me know if you have any questions at all.

0

P
Matt Studdert 13,611

@mattstuddert

Posted

@mariakourtesi you're welcome! Always happy to help 🙂

0
Maria 20

@mariakourtesi

Posted

@mattstuddert Hi Matt, thank you so much for your feedback! I really appreciate it, it's fantastic. I honestly, thought that nobody would care to check my code, you are a star! I'll make the changes you suggested. Thank you so much for the tutorials too. Have a lovely day!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord