@mattstuddert
Posted
Great work on this challenge Rinat! Here are some pointers after taking a look at your code:
- For the main call-to-actions, you're currently using the
button
element. If this were a live site, you'd expect those to link off to another page, so I would recommend adding them asa
tags to be more realistic. - Currently, your
footer
links have this HTML structure:
<ul>
<a href="#"><li>About Us</li></a>
<a href="#"><li>What We Do</li></a>
<a href="#"><li>FAQ</li></a>
</ul>
Only a li
element can be a direct child of a ul
, so this is currently invalid HTML. I would suggest switching the li
and a
.
It's great that you used this challenge to practice so many tools and methodologies. How did you get on with it all? Did you like using any of them in particular?
@astrakhanRinat
Posted
Hi, Matt! Thank you for your code review. I fixed all my bugs. I become smarter and wiser! :) Gulp plus Suss and Browser Sync are very convenient tools. And Wes Bos is very cool! :)
@mattstuddert
Posted
Great work! Haha, yeah Wes Bos is a great instructor!