Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

I tried to use BEM, Sass, Flexbox, Grid, SVG, Gulp and Autoprefixer :)

Rinat 50

@astrakhanRinat


Design comparison


SolutionDesign

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Great work on this challenge Rinat! Here are some pointers after taking a look at your code:

  • For the main call-to-actions, you're currently using the button element. If this were a live site, you'd expect those to link off to another page, so I would recommend adding them as a tags to be more realistic.
  • Currently, your footer links have this HTML structure:
<ul>
  <a href="#"><li>About Us</li></a>
  <a href="#"><li>What We Do</li></a>
  <a href="#"><li>FAQ</li></a>
</ul>

Only a li element can be a direct child of a ul, so this is currently invalid HTML. I would suggest switching the li and a.

It's great that you used this challenge to practice so many tools and methodologies. How did you get on with it all? Did you like using any of them in particular?

1

Rinat 50

@astrakhanRinat

Posted

Hi, Matt! Thank you for your code review. I fixed all my bugs. I become smarter and wiser! :) Gulp plus Suss and Browser Sync are very convenient tools. And Wes Bos is very cool! :)

0
P
Matt Studdert 13,611

@mattstuddert

Posted

Great work! Haha, yeah Wes Bos is a great instructor!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord