@mattstuddert
Posted
Great work Lucas, your solution looks great!
Here are some pointers I've seen from looking at your code:
- At the moment you have this HTML code for the top area of the page:
<div class="logo">
<img src="images/logo.svg" alt="Logo">
</div>
Whereas I'd recommend something more like this:
<header>
<img class="logo" src="images/logo.svg" alt="Huddle">
</header>
The use of the header
element here is more meaningful than a div
. Also, having the text of "Huddle" in the img
alt
attribute would read out the word "Huddle" to people using screen readers, as opposed to the more general word "Logo".
-
I'd also follow on from that by recommending using the
main
andfooter
elements where appropriate instead ofdiv
tags in your HTML. -
You don't currently have a
h1
on the page and are using ah2
for the main title. I'd recommend swapping that to ah1
, as that is the page title for this site. -
Inside your media query, you could also change the
background-image
of thebody
to the mobile background image to match up to the design.
I hope those points help you out. If you have any questions let me know.
Keep up the great work!