Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

html5, css3, flexbox

@Kelvinblaze

Desktop design screenshot for the Fylo dark theme landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Awesome work on this, it looks great! Here are a few pointers after looking at your code:

  • Be sure to only ever use one h1 on a page otherwise, the content hierarchy can be messed up for people using screen readers
  • For the call-to-actions, you don’t need to have a button wrapped around the anchor tag. Just keep the anchor tag and style it directly.
  • The images for the curved sections could use ::before or ::after pseudo-elements with a background-image instead of an img tag. These are purely decorative images and so shouldn’t necessarily be in the HTML. Here’s a link to read up on these some more

Hope these pointers help. Keep it up! 🙂

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord