P
Matt Studdert• 13,611
@mattstuddert
Posted
Great work on completing this challenge! 👍
Here are a few pointers after taking a look at the code:
- In your HTML, you've currently got a
h1
and ah3
, but noh2
. I would recommend avoiding skipping heading levels as this can create accessibility issues when defining the HTML outline and the content hierarchy. - I always recommend never using IDs for styling purposes as they're too specific and also can't be reused on the same page. Here's a great article on Dev.to about specificity if you would like to read up further.
- In your next project, have a go at using
min-width
media queries instead ofmax-width
. This would mean working from a mobile-first approach and optimises your CSS styles for mobile users. Meaning they load in the fewest possible styles.
I hope those tips helped! Let me know if you have any questions 🙂
1
Kristupas• 20
@krisatthenet
Posted
Thanks so much for your feedback! I will refactor it a bit based based on your first two points and will do the next one with min-width!
0