P
Matt Studdert• 13,611
@mattstuddert
Posted
Great work on completing this challenge! 🙂👍
Here are some things I picked up on while taking a look at your code:
- At the moment you haven't got any headings on the page. I'd always recommend adding headings to give your content a hierarchy.
- You've got a
footerelement in your HTML, but that's the only HTML5 structural element you're using. Have a look into other elements likeheader,sectionandmain, which could also be used on this page to add more meaning to your HTML. - Whenever you add icons as links to social media channels, make sure you either add text inside or add an
aria-labelto make them accessible. Here's a tweet I posted about accessible icons for more information. - I'd always recommend staying away from using IDs for styling purposes as they're overly specific and also can't be reused on the page.
Great work using min-width media queries to go mobile-first! 🙌
I hope those tips help. Let me know if you have any questions!
1
@Latheresienne
Posted
Thanks you so much for your feedback! I will improve my code before the weekend. Thanks to check it again that time.
The error message does not apper in red. Any tips? I try hard to make red but it is not working yet.
This is currently my first month on my journey to become a fullstack developer in 6 months. Any advice will be welcome.
0
